playback: re-add replaygain off mode

It was honestly foolish for me to recommend retagging.

Resolves #746.
This commit is contained in:
Alexander Capehart 2024-04-04 12:31:02 -06:00
parent dc51c84c54
commit da07be26f4
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
5 changed files with 14 additions and 2 deletions

View file

@ -102,7 +102,7 @@ object IntegerTable {
/** Sort.Mode.ByDateAdded */ /** Sort.Mode.ByDateAdded */
const val SORT_BY_DATE_ADDED = 0xA118 const val SORT_BY_DATE_ADDED = 0xA118
/** ReplayGainMode.Off (No longer used but still reserved) */ /** ReplayGainMode.Off (No longer used but still reserved) */
// const val REPLAY_GAIN_MODE_OFF = 0xA110 const val REPLAY_GAIN_MODE_OFF = 0xA110
/** ReplayGainMode.Track */ /** ReplayGainMode.Track */
const val REPLAY_GAIN_MODE_TRACK = 0xA111 const val REPLAY_GAIN_MODE_TRACK = 0xA111
/** ReplayGainMode.Album */ /** ReplayGainMode.Album */

View file

@ -29,6 +29,8 @@ import org.oxycblt.auxio.R
* @author Alexander Capehart (OxygenCobalt) * @author Alexander Capehart (OxygenCobalt)
*/ */
enum class ReplayGainMode { enum class ReplayGainMode {
/** Do not apply any ReplayGain adjustments. */
OFF,
/** Apply the track gain, falling back to the album gain if the track gain is not found. */ /** Apply the track gain, falling back to the album gain if the track gain is not found. */
TRACK, TRACK,
/** Apply the album gain, falling back to the track gain if the album gain is not found. */ /** Apply the album gain, falling back to the track gain if the album gain is not found. */
@ -45,6 +47,7 @@ enum class ReplayGainMode {
*/ */
fun fromIntCode(intCode: Int) = fun fromIntCode(intCode: Int) =
when (intCode) { when (intCode) {
IntegerTable.REPLAY_GAIN_MODE_OFF -> OFF
IntegerTable.REPLAY_GAIN_MODE_TRACK -> TRACK IntegerTable.REPLAY_GAIN_MODE_TRACK -> TRACK
IntegerTable.REPLAY_GAIN_MODE_ALBUM -> ALBUM IntegerTable.REPLAY_GAIN_MODE_ALBUM -> ALBUM
IntegerTable.REPLAY_GAIN_MODE_DYNAMIC -> DYNAMIC IntegerTable.REPLAY_GAIN_MODE_DYNAMIC -> DYNAMIC

View file

@ -119,6 +119,11 @@ constructor(
// ReplayGain is configurable, so determine what to do based off of the mode. // ReplayGain is configurable, so determine what to do based off of the mode.
val resolvedAdjustment = val resolvedAdjustment =
when (playbackSettings.replayGainMode) { when (playbackSettings.replayGainMode) {
// User wants no adjustment.
ReplayGainMode.OFF -> {
logD("ReplayGain is off")
null
}
// User wants track gain to be preferred. Default to album gain only if // User wants track gain to be preferred. Default to album gain only if
// there is no track gain. // there is no track gain.
ReplayGainMode.TRACK -> { ReplayGainMode.TRACK -> {

View file

@ -139,12 +139,14 @@
</integer-array> </integer-array>
<string-array name="entries_replay_gain"> <string-array name="entries_replay_gain">
<item>@string/set_replay_gain_mode_off</item>
<item>@string/set_replay_gain_mode_track</item> <item>@string/set_replay_gain_mode_track</item>
<item>@string/set_replay_gain_mode_album</item> <item>@string/set_replay_gain_mode_album</item>
<item>@string/set_replay_gain_mode_dynamic</item> <item>@string/set_replay_gain_mode_dynamic</item>
</string-array> </string-array>
<integer-array name="values_replay_gain"> <integer-array name="values_replay_gain">
<item>@integer/replay_gain_off</item>
<item>@integer/replay_gain_track</item> <item>@integer/replay_gain_track</item>
<item>@integer/replay_gain_album</item> <item>@integer/replay_gain_album</item>
<item>@integer/replay_gain_dynamic</item> <item>@integer/replay_gain_dynamic</item>
@ -161,6 +163,7 @@
<integer name="play_song_from_genre">0xA122</integer> <integer name="play_song_from_genre">0xA122</integer>
<integer name="play_song_by_itself">0xA124</integer> <integer name="play_song_by_itself">0xA124</integer>
<integer name="replay_gain_off">0xA110</integer>
<integer name="replay_gain_track">0xA111</integer> <integer name="replay_gain_track">0xA111</integer>
<integer name="replay_gain_album">0xA112</integer> <integer name="replay_gain_album">0xA112</integer>
<integer name="replay_gain_dynamic">0xA113</integer> <integer name="replay_gain_dynamic">0xA113</integer>

View file

@ -290,8 +290,9 @@
<string name="set_repeat_pause_desc">Pause when a song repeats</string> <string name="set_repeat_pause_desc">Pause when a song repeats</string>
<string name="set_remember_pause">Remember pause</string> <string name="set_remember_pause">Remember pause</string>
<string name="set_remember_pause_desc">Remain playing/paused when skipping or editing queue</string> <string name="set_remember_pause_desc">Remain playing/paused when skipping or editing queue</string>
<string name="set_replay_gain">ReplayGain</string> <string name="set_replay_gain">Volume normalization</string>
<string name="set_replay_gain_mode">ReplayGain strategy</string> <string name="set_replay_gain_mode">ReplayGain strategy</string>
<string name="set_replay_gain_mode_off">Off</string>
<string name="set_replay_gain_mode_track">Prefer track</string> <string name="set_replay_gain_mode_track">Prefer track</string>
<string name="set_replay_gain_mode_album">Prefer album</string> <string name="set_replay_gain_mode_album">Prefer album</string>
<string name="set_replay_gain_mode_dynamic">Prefer album if one is playing</string> <string name="set_replay_gain_mode_dynamic">Prefer album if one is playing</string>