From d0280fffb27e538b654e4350c8cdc435f10d4c5f Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Tue, 23 Mar 2021 19:21:44 -0600 Subject: [PATCH] Fix crash on PlaybackService destruction Fix a destructive crash when PlaybackService attempted to release a wakelock that wasn't being held. --- .../org/oxycblt/auxio/playback/system/PlaybackService.kt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/src/main/java/org/oxycblt/auxio/playback/system/PlaybackService.kt b/app/src/main/java/org/oxycblt/auxio/playback/system/PlaybackService.kt index c60a76e5f..2e361fe26 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/system/PlaybackService.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/system/PlaybackService.kt @@ -169,7 +169,7 @@ class PlaybackService : Service(), Player.EventListener, PlaybackStateManager.Ca player.release() mediaSession.release() audioReactor.release() - wakeLock.release() + releaseWakelock() playbackManager.removeCallback(this) settingsManager.removeCallback(this) @@ -440,8 +440,6 @@ class PlaybackService : Service(), Player.EventListener, PlaybackStateManager.Ca * Hold the wakelock for the default amount of time [25 Seconds] */ private fun holdWakelock() { - logD("Holding wakelock.") - wakeLock.acquire(WAKELOCK_TIME) } @@ -449,8 +447,6 @@ class PlaybackService : Service(), Player.EventListener, PlaybackStateManager.Ca * Release the wakelock if its currently being held. */ private fun releaseWakelock() { - logD("Attempting to release the wakelock.") - if (wakeLock.isHeld) { wakeLock.release() }