From c9ddda2ebd25cd3d150d5f9f46f025d4c2b8bf1d Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Sun, 12 Feb 2023 21:52:00 -0700 Subject: [PATCH] home: fix visual clipping on shuffle fab shadow Fix visual clipping on the shuffle FAB's shadow. Turns out padding, while slower, is actually the better inset handling method, as it allows me to avoid visual clipping in some cases. --- CHANGELOG.md | 3 +++ app/src/main/java/org/oxycblt/auxio/home/EdgeFrameLayout.kt | 3 ++- app/src/main/res/values/styles_ui.xml | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0bc0af533..2fbdc1ee5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,12 +10,15 @@ track/disc fields - Music loading has been made slightly faster - Improved sort menu usability +- Fall back to `TXXX:RELEASETYPE` on ID3v2 files #### What's Fixed - Fixed non-functioning "repeat all" repeat mode +- Fixed visual clipping of shuffle button shadow #### Dev/Meta - Started using dependency injection +- Updated to MDC 1.8.0 alpha-01 ## 3.0.2 diff --git a/app/src/main/java/org/oxycblt/auxio/home/EdgeFrameLayout.kt b/app/src/main/java/org/oxycblt/auxio/home/EdgeFrameLayout.kt index 87032bfe6..81fe40edd 100644 --- a/app/src/main/java/org/oxycblt/auxio/home/EdgeFrameLayout.kt +++ b/app/src/main/java/org/oxycblt/auxio/home/EdgeFrameLayout.kt @@ -22,6 +22,7 @@ import android.util.AttributeSet import android.view.WindowInsets import android.widget.FrameLayout import androidx.annotation.AttrRes +import androidx.core.view.updatePadding import org.oxycblt.auxio.util.systemBarInsetsCompat /** @@ -38,7 +39,7 @@ constructor(context: Context, attrs: AttributeSet? = null, @AttrRes defStyleAttr override fun onApplyWindowInsets(insets: WindowInsets): WindowInsets { // Prevent excessive layouts by using translation instead of padding. - translationY = -insets.systemBarInsetsCompat.bottom.toFloat() + updatePadding(bottom = insets.systemBarInsetsCompat.bottom) return insets } } diff --git a/app/src/main/res/values/styles_ui.xml b/app/src/main/res/values/styles_ui.xml index 7dfde25ce..b184ad116 100644 --- a/app/src/main/res/values/styles_ui.xml +++ b/app/src/main/res/values/styles_ui.xml @@ -5,6 +5,7 @@