From c8571a4df30f29a22b367622ef1d7eed98b6e866 Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Sun, 14 Apr 2024 12:16:38 -0600 Subject: [PATCH] playback: fix broken play actions --- .../main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt | 2 ++ .../java/org/oxycblt/auxio/playback/state/PlaybackCommand.kt | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt index 4326e993a..3cccaa0f4 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt @@ -267,6 +267,7 @@ constructor( val params = commandFactory.songFromArtist(song, artist, shuffle) if (params != null) { playbackManager.play(params) + return } logD( "Cannot use given artist parameter for $song [$artist from ${song.artists}], showing choice dialog") @@ -277,6 +278,7 @@ constructor( val params = commandFactory.songFromGenre(song, genre, shuffle) if (params != null) { playbackManager.play(params) + return } logD( "Cannot use given genre parameter for $song [$genre from ${song.genres}], showing choice dialog") diff --git a/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackCommand.kt b/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackCommand.kt index 90e435a26..82685f051 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackCommand.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackCommand.kt @@ -162,7 +162,7 @@ constructor( sort: Sort, shuffle: ShuffleMode ): PlaybackCommand? { - if (queue.isEmpty() || song !in queue) { + if (queue.isEmpty() || (song != null && song !in queue)) { return null } return newCommand(song, parent, sort.songs(queue), shuffle)