Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

music: use plural vorbis artist tags

Browse source 
Use plural variants of vorbis artist/album artist tags.

Some people add these tags to signal the artist makeup of a song
when a player supports multiple artists while still allowing less
sophisticated players to operate with single-artist tags.
This commit is contained in:
Alexander Capehart 2022-09-24 09:13:15 -06:00
parent b58fce9414
commit c3de8fe4fd
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/org/oxycblt/auxio/music/Music.kt
View file

@ -107,8 +107,6 @@ sealed class Music : Item {
* Please don't try to do anything interesting with this and just assume it's a black box * Please don't try to do anything interesting with this and just assume it's a black box
* that can only be compared, serialized, and deserialized. * that can only be compared, serialized, and deserialized.
* *
* TODO: MusicBrainz tags
*
* @author OxygenCobalt * @author OxygenCobalt
*/ */
@Parcelize @Parcelize

8
app/src/main/java/org/oxycblt/auxio/music/extractor/MetadataExtractor.kt
View file

@ -303,13 +303,13 @@ class Task(context: Context, private val raw: Song.Raw) {
// Artist // Artist
tags["MUSICBRAINZ_ARTISTID"]?.let { raw.artistMusicBrainzIds = it } tags["MUSICBRAINZ_ARTISTID"]?.let { raw.artistMusicBrainzIds = it }
tags["ARTIST"]?.let { raw.artistNames = it } (tags["ARTISTS"] ?: tags["ARTIST"])?.let { raw.artistNames = it }
tags["ARTISTSORT"]?.let { raw.artistSortNames = it } (tags["ARTISTS_SORT"] ?: tags["ARTISTSORT"])?.let { raw.artistSortNames = it }
// Album artist // Album artist
tags["MUSICBRAINZ_ALBUMARTISTID"]?.let { raw.albumArtistMusicBrainzIds = it } tags["MUSICBRAINZ_ALBUMARTISTID"]?.let { raw.albumArtistMusicBrainzIds = it }
tags["ALBUMARTIST"]?.let { raw.albumArtistNames = it } (tags["ALBUMARTISTS"] ?: tags["ALBUMARTIST"])?.let { raw.albumArtistNames = it }
tags["ALBUMARTISTSORT"]?.let { raw.albumArtistSortNames = it } (tags["ALBUMARTISTS_SORT"] ?: tags["ALBUMARTISTSORT"])?.let { raw.albumArtistSortNames = it }
// Genre // Genre
tags["GENRE"]?.let { raw.genreNames = it } tags["GENRE"]?.let { raw.genreNames = it }