diff --git a/app/src/main/java/org/oxycblt/auxio/detail/ArtistDetailFragment.kt b/app/src/main/java/org/oxycblt/auxio/detail/ArtistDetailFragment.kt index 1addcf673..d15000328 100644 --- a/app/src/main/java/org/oxycblt/auxio/detail/ArtistDetailFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/detail/ArtistDetailFragment.kt @@ -106,4 +106,10 @@ class ArtistDetailFragment : DetailFragment() { return binding.root } + + override fun onResume() { + super.onResume() + + detailModel.updateNavigationStatus(false) + } } diff --git a/app/src/main/java/org/oxycblt/auxio/library/LibraryFragment.kt b/app/src/main/java/org/oxycblt/auxio/library/LibraryFragment.kt index a1b00305b..362532668 100644 --- a/app/src/main/java/org/oxycblt/auxio/library/LibraryFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/library/LibraryFragment.kt @@ -15,7 +15,6 @@ import androidx.fragment.app.activityViewModels import androidx.navigation.fragment.findNavController import androidx.transition.Fade import androidx.transition.TransitionManager -import org.oxycblt.auxio.MainFragmentDirections import org.oxycblt.auxio.R import org.oxycblt.auxio.databinding.FragmentLibraryBinding import org.oxycblt.auxio.library.adapters.LibraryAdapter @@ -157,18 +156,6 @@ class LibraryFragment : Fragment(), SearchView.OnQueryTextListener { } } - playbackModel.navToPlayingSong.observe(viewLifecycleOwner) { - if (it) { - findNavController().navigate( - MainFragmentDirections.actionShowAlbum( - playbackModel.song.value!!.album.id, true - ) - ) - - playbackModel.doneWithNavToPlayingSong() - } - } - Log.d(this::class.simpleName, "Fragment created.") return binding.root diff --git a/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackFragment.kt b/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackFragment.kt index b62e770d6..1ce42197a 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackFragment.kt @@ -49,17 +49,10 @@ class CompactPlaybackFragment : Fragment() { binding.song = MusicStore.getInstance().songs[0] binding.playbackModel = playbackModel - binding.root.apply { - setOnClickListener { - findNavController().navigate( - MainFragmentDirections.actionGoToPlayback() - ) - } - - setOnLongClickListener { - playbackModel.navigateToPlayingSong() - true - } + binding.root.setOnClickListener { + findNavController().navigate( + MainFragmentDirections.actionGoToPlayback() + ) } // --- VIEWMODEL SETUP --- diff --git a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt index 2596e5084..b00f29393 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackViewModel.kt @@ -19,6 +19,7 @@ import org.oxycblt.auxio.playback.state.PlaybackStateManager /** * The ViewModel that provides a UI-Focused frontend for [PlaybackStateManager]. + * TODO: Implement navigation to playing album/artist * @author OxygenCobalt */ class PlaybackViewModel : ViewModel(), PlaybackStateManager.Callback { @@ -59,9 +60,6 @@ class PlaybackViewModel : ViewModel(), PlaybackStateManager.Callback { private val mIsSeeking = MutableLiveData(false) val isSeeking: LiveData get() = mIsSeeking - private val mNavToPlayingSong = MutableLiveData(false) - val navToPlayingSong: LiveData get() = mNavToPlayingSong - val formattedPosition = Transformations.map(mPosition) { it.toDuration() } @@ -265,14 +263,6 @@ class PlaybackViewModel : ViewModel(), PlaybackStateManager.Callback { mIsSeeking.value = value } - fun navigateToPlayingSong() { - mNavToPlayingSong.value = true - } - - fun doneWithNavToPlayingSong() { - mNavToPlayingSong.value = false - } - // --- OVERRIDES --- override fun onCleared() { diff --git a/app/src/main/res/layout/fragment_album_detail.xml b/app/src/main/res/layout/fragment_album_detail.xml index 98577e32c..0c5a1b523 100644 --- a/app/src/main/res/layout/fragment_album_detail.xml +++ b/app/src/main/res/layout/fragment_album_detail.xml @@ -86,6 +86,7 @@ android:layout_marginStart="@dimen/margin_medium" android:clickable="true" android:focusable="true" + android:background="@drawable/ui_ripple" android:onClick="@{() -> detailModel.doNavToParent()}" android:text="@{album.artist.name}" android:textAppearance="?android:attr/textAppearanceListItem" diff --git a/app/src/main/res/navigation/nav_main.xml b/app/src/main/res/navigation/nav_main.xml index 838653968..40d5a0d83 100644 --- a/app/src/main/res/navigation/nav_main.xml +++ b/app/src/main/res/navigation/nav_main.xml @@ -25,27 +25,6 @@ android:name="org.oxycblt.auxio.MainFragment" android:label="MainFragment" tools:layout="@layout/fragment_main"> - - - - - - - - - - - - - - - -