From b51ec756ded32805e4f1f22f1b3c223be5c0ac57 Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Thu, 5 Aug 2021 17:00:59 -0600 Subject: [PATCH] widgets: simplify layouts Simplify the layouts used by widgets, moving the more version-specific attributes into settings. --- app/src/main/AndroidManifest.xml | 2 +- .../auxio/widgets/forms/FullWidgetForm.kt | 2 +- .../auxio/widgets/forms/SmallWidgetForm.kt | 2 +- .../res/layout-land/fragment_playback.xml | 5 +- app/src/main/res/layout-v31/widget_full.xml | 101 ------------------ app/src/main/res/layout-v31/widget_small.xml | 85 --------------- .../layout-xlarge-land/fragment_playback.xml | 4 +- .../res/layout-xlarge/fragment_playback.xml | 7 +- app/src/main/res/layout/fragment_playback.xml | 2 +- app/src/main/res/layout/widget_default.xml | 2 +- app/src/main/res/layout/widget_full.xml | 45 ++------ app/src/main/res/layout/widget_small.xml | 45 +------- app/src/main/res/values-de/strings.xml | 2 - app/src/main/res/values-es/strings.xml | 2 - app/src/main/res/values-nl/strings.xml | 2 - app/src/main/res/values-v31/styles_ui.xml | 8 ++ app/src/main/res/values/dimens.xml | 1 + app/src/main/res/values/strings.xml | 10 +- app/src/main/res/values/styles_component.xml | 44 +++++++- app/src/main/res/values/styles_ui.xml | 28 ++++- 20 files changed, 100 insertions(+), 299 deletions(-) delete mode 100644 app/src/main/res/layout-v31/widget_full.xml delete mode 100644 app/src/main/res/layout-v31/widget_small.xml create mode 100644 app/src/main/res/values-v31/styles_ui.xml diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index fb8b9f303..20f58f8aa 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -57,7 +57,7 @@ android:roundIcon="@mipmap/ic_launcher_round" /> diff --git a/app/src/main/java/org/oxycblt/auxio/widgets/forms/FullWidgetForm.kt b/app/src/main/java/org/oxycblt/auxio/widgets/forms/FullWidgetForm.kt index a2a9af3e3..bc6094091 100644 --- a/app/src/main/java/org/oxycblt/auxio/widgets/forms/FullWidgetForm.kt +++ b/app/src/main/java/org/oxycblt/auxio/widgets/forms/FullWidgetForm.kt @@ -70,7 +70,7 @@ class FullWidgetForm : WidgetForm(R.layout.widget_full) { views.setCharSequence( R.id.widget_cover, "setContentDescription", - context.getString(R.string.description_placeholder_cover) + context.getString(R.string.description_no_cover) ) } diff --git a/app/src/main/java/org/oxycblt/auxio/widgets/forms/SmallWidgetForm.kt b/app/src/main/java/org/oxycblt/auxio/widgets/forms/SmallWidgetForm.kt index 951d1a34a..9f7353c0e 100644 --- a/app/src/main/java/org/oxycblt/auxio/widgets/forms/SmallWidgetForm.kt +++ b/app/src/main/java/org/oxycblt/auxio/widgets/forms/SmallWidgetForm.kt @@ -55,7 +55,7 @@ class SmallWidgetForm : WidgetForm(R.layout.widget_small) { views.setCharSequence( R.id.widget_cover, "setContentDescription", - context.getString(R.string.description_placeholder_cover) + context.getString(R.string.description_no_cover) ) } diff --git a/app/src/main/res/layout-land/fragment_playback.xml b/app/src/main/res/layout-land/fragment_playback.xml index 3ef26d1a2..e221f3654 100644 --- a/app/src/main/res/layout-land/fragment_playback.xml +++ b/app/src/main/res/layout-land/fragment_playback.xml @@ -148,7 +148,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/app/src/main/res/layout-v31/widget_small.xml b/app/src/main/res/layout-v31/widget_small.xml deleted file mode 100644 index a772f454a..000000000 --- a/app/src/main/res/layout-v31/widget_small.xml +++ /dev/null @@ -1,85 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/app/src/main/res/layout-xlarge-land/fragment_playback.xml b/app/src/main/res/layout-xlarge-land/fragment_playback.xml index ecf869ff0..d215cbec9 100644 --- a/app/src/main/res/layout-xlarge-land/fragment_playback.xml +++ b/app/src/main/res/layout-xlarge-land/fragment_playback.xml @@ -103,9 +103,9 @@ diff --git a/app/src/main/res/layout/widget_full.xml b/app/src/main/res/layout/widget_full.xml index 3a5ae61c7..402f4c174 100644 --- a/app/src/main/res/layout/widget_full.xml +++ b/app/src/main/res/layout/widget_full.xml @@ -9,44 +9,21 @@ + style="@style/WidgetPanel"> diff --git a/app/src/main/res/layout/widget_small.xml b/app/src/main/res/layout/widget_small.xml index df7f9c818..6a05f68e1 100644 --- a/app/src/main/res/layout/widget_small.xml +++ b/app/src/main/res/layout/widget_small.xml @@ -9,44 +9,21 @@ + style="@style/WidgetPanel"> - - diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index 6ea6cd4d0..bcec02d57 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -109,8 +109,6 @@ Abspielen oder Pausieren Zu letzter Lied springen Zu nächster Lied springen - Zufällig anschalten - Zufällig ausschalten Art die Wiederholung ändern Suchanfrage löschen diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index 963f00ff8..60ccd6f40 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -112,8 +112,6 @@ Reproducir o Pausar Saltar a la siguiente canción Saltar a la última canción - Activar la reproducción aleatoria - Desactivar la reproducción aleatoria Cambiar el modo de repetición Limpiar cola diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index ed2a971a2..50310f0d9 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -110,8 +110,6 @@ Afspelen/Pauzeren Naar volgend nummer gaan Naar het laatste nummer gaan - Zet shuffle aan - Zet shuffle uit Herhaalfunctie wijzigen Wachtrij wissen diff --git a/app/src/main/res/values-v31/styles_ui.xml b/app/src/main/res/values-v31/styles_ui.xml new file mode 100644 index 000000000..f0e16879d --- /dev/null +++ b/app/src/main/res/values-v31/styles_ui.xml @@ -0,0 +1,8 @@ + + + + + + + + + + + + + + @@ -144,6 +172,18 @@ bounds + + + - - + + + + \ No newline at end of file