From aaba858fcf5a9cf7e0d29b7c1dfc776934ecdc71 Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Thu, 8 Jun 2023 10:15:04 -0600 Subject: [PATCH] all: only use one fallback method for dbs Only use fallbackToDestructiveMigration for all databases. I thought you had to selectively enable downgrading as well, but apparently that disables other destructive migrations. This was not obvious at all and caused countless issues. Absolutely flooring. --- app/src/main/java/org/oxycblt/auxio/music/cache/CacheModule.kt | 1 - app/src/main/java/org/oxycblt/auxio/music/user/UserModule.kt | 2 -- .../org/oxycblt/auxio/playback/persist/PersistenceModule.kt | 2 -- 3 files changed, 5 deletions(-) diff --git a/app/src/main/java/org/oxycblt/auxio/music/cache/CacheModule.kt b/app/src/main/java/org/oxycblt/auxio/music/cache/CacheModule.kt index 281cb6f4a..16de62c99 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/cache/CacheModule.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/cache/CacheModule.kt @@ -43,7 +43,6 @@ class CacheRoomModule { Room.databaseBuilder( context.applicationContext, CacheDatabase::class.java, "music_cache.db") .fallbackToDestructiveMigration() - .fallbackToDestructiveMigrationOnDowngrade() .build() @Provides fun cachedSongsDao(database: CacheDatabase) = database.cachedSongsDao() diff --git a/app/src/main/java/org/oxycblt/auxio/music/user/UserModule.kt b/app/src/main/java/org/oxycblt/auxio/music/user/UserModule.kt index 10e55c5bd..10a42edb1 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/user/UserModule.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/user/UserModule.kt @@ -43,7 +43,5 @@ class UserRoomModule { Room.databaseBuilder( context.applicationContext, UserMusicDatabase::class.java, "user_music.db") .fallbackToDestructiveMigration() - .fallbackToDestructiveMigrationFrom(0) - .fallbackToDestructiveMigrationOnDowngrade() .build() } diff --git a/app/src/main/java/org/oxycblt/auxio/playback/persist/PersistenceModule.kt b/app/src/main/java/org/oxycblt/auxio/playback/persist/PersistenceModule.kt index 76af5369b..73ad12e07 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/persist/PersistenceModule.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/persist/PersistenceModule.kt @@ -45,8 +45,6 @@ class PersistenceRoomModule { PersistenceDatabase::class.java, "playback_persistence.db") .fallbackToDestructiveMigration() - .fallbackToDestructiveMigrationFrom(1) - .fallbackToDestructiveMigrationOnDowngrade() .build() @Provides fun playbackStateDao(database: PersistenceDatabase) = database.playbackStateDao()