From 8a8586968fcca33fad8d704a2ce506d611ddcbcd Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Sun, 21 May 2023 20:04:18 -0600 Subject: [PATCH] all: cleanup Final pre-release cleanup. --- .../java/org/oxycblt/auxio/IntegerTable.kt | 6 ++-- .../detail/list/PlaylistDetailListAdapter.kt | 5 ++- .../oxycblt/auxio/music/device/RawMusic.kt | 1 - .../music/picker/RenamePlaylistDialog.kt | 3 +- .../auxio/music/user/UserMusicDatabase.kt | 2 +- app/src/main/res/layout/item_divider.xml | 4 --- app/src/main/res/menu/menu_playlist_sort.xml | 33 ------------------- app/src/main/res/values-be/strings.xml | 1 - app/src/main/res/values-cs/strings.xml | 1 - app/src/main/res/values-de/strings.xml | 1 - app/src/main/res/values-es/strings.xml | 1 - app/src/main/res/values-fi/strings.xml | 1 - app/src/main/res/values-fr/strings.xml | 1 - app/src/main/res/values-gl/strings.xml | 1 - app/src/main/res/values-hr/strings.xml | 1 - app/src/main/res/values-it/strings.xml | 1 - app/src/main/res/values-ja/strings.xml | 1 - app/src/main/res/values-ko/strings.xml | 1 - app/src/main/res/values-lt/strings.xml | 1 - app/src/main/res/values-ml/strings.xml | 1 - app/src/main/res/values-pl/strings.xml | 1 - app/src/main/res/values-ro/strings.xml | 1 - app/src/main/res/values-ru/strings.xml | 1 - app/src/main/res/values-tr/strings.xml | 1 - app/src/main/res/values-uk/strings.xml | 1 - app/src/main/res/values-zh-rCN/strings.xml | 1 - app/src/main/res/values/settings.xml | 1 - app/src/main/res/values/strings.xml | 1 - 28 files changed, 6 insertions(+), 69 deletions(-) delete mode 100644 app/src/main/res/layout/item_divider.xml delete mode 100644 app/src/main/res/menu/menu_playlist_sort.xml diff --git a/app/src/main/java/org/oxycblt/auxio/IntegerTable.kt b/app/src/main/java/org/oxycblt/auxio/IntegerTable.kt index db14d5882..d0bff5315 100644 --- a/app/src/main/java/org/oxycblt/auxio/IntegerTable.kt +++ b/app/src/main/java/org/oxycblt/auxio/IntegerTable.kt @@ -51,10 +51,8 @@ object IntegerTable { const val VIEW_TYPE_DISC_HEADER = 0xA00B /** EditHeaderViewHolder */ const val VIEW_TYPE_EDIT_HEADER = 0xA00C - /** ConfirmHeaderViewHolder */ - const val VIEW_TYPE_CONFIRM_HEADER = 0xA00D - /** EditableSongViewHolder */ - const val VIEW_TYPE_EDITABLE_SONG = 0xA00E + /** PlaylistSongViewHolder */ + const val VIEW_TYPE_PLAYLIST_SONG = 0xA00E /** "Music playback" notification code */ const val PLAYBACK_NOTIFICATION_CODE = 0xA0A0 /** "Music loading" notification code */ diff --git a/app/src/main/java/org/oxycblt/auxio/detail/list/PlaylistDetailListAdapter.kt b/app/src/main/java/org/oxycblt/auxio/detail/list/PlaylistDetailListAdapter.kt index 47737f7f7..7b4147621 100644 --- a/app/src/main/java/org/oxycblt/auxio/detail/list/PlaylistDetailListAdapter.kt +++ b/app/src/main/java/org/oxycblt/auxio/detail/list/PlaylistDetailListAdapter.kt @@ -139,8 +139,7 @@ class PlaylistDetailListAdapter(private val listener: Listener) : } /** - * A [RecyclerView.ViewHolder] that displays a [SortHeader] and it's actions. Use [from] to create - * an instance. + * A [Header] variant that displays an edit button. * * @param titleRes The string resource to use as the header title * @author Alexander Capehart (OxygenCobalt) @@ -265,7 +264,7 @@ private constructor(private val binding: ItemEditableSongBinding) : companion object { /** A unique ID for this [RecyclerView.ViewHolder] type. */ - const val VIEW_TYPE = IntegerTable.VIEW_TYPE_EDITABLE_SONG + const val VIEW_TYPE = IntegerTable.VIEW_TYPE_PLAYLIST_SONG /** * Create a new instance. diff --git a/app/src/main/java/org/oxycblt/auxio/music/device/RawMusic.kt b/app/src/main/java/org/oxycblt/auxio/music/device/RawMusic.kt index 8c91f09f9..23b02b2f1 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/device/RawMusic.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/device/RawMusic.kt @@ -23,7 +23,6 @@ import org.oxycblt.auxio.music.* import org.oxycblt.auxio.music.fs.Directory import org.oxycblt.auxio.music.info.Date import org.oxycblt.auxio.music.info.ReleaseType -import org.oxycblt.auxio.music.metadata.* /** * Raw information about a [SongImpl] obtained from the filesystem/Extractor instances. diff --git a/app/src/main/java/org/oxycblt/auxio/music/picker/RenamePlaylistDialog.kt b/app/src/main/java/org/oxycblt/auxio/music/picker/RenamePlaylistDialog.kt index f13951212..fcc8b2538 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/picker/RenamePlaylistDialog.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/picker/RenamePlaylistDialog.kt @@ -52,8 +52,7 @@ class RenamePlaylistDialog : ViewBindingDialogFragment val playlist = unlikelyToBeNull(pickerModel.currentPlaylistToRename.value) val chosenName = pickerModel.chosenName.value as ChosenName.Valid diff --git a/app/src/main/java/org/oxycblt/auxio/music/user/UserMusicDatabase.kt b/app/src/main/java/org/oxycblt/auxio/music/user/UserMusicDatabase.kt index ed790640a..087e46b35 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/user/UserMusicDatabase.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/user/UserMusicDatabase.kt @@ -106,7 +106,7 @@ interface PlaylistDao { } /** - * Replace the currently-stored [Song]s of the current playlist entry. + * Replace the currently stored songs of the given playlist entry. * * @param playlistUid The [Music.UID] of the playlist to update. * @param songs The [PlaylistSong] representing the new list of songs to be placed in the diff --git a/app/src/main/res/layout/item_divider.xml b/app/src/main/res/layout/item_divider.xml deleted file mode 100644 index 4767eae41..000000000 --- a/app/src/main/res/layout/item_divider.xml +++ /dev/null @@ -1,4 +0,0 @@ - - \ No newline at end of file diff --git a/app/src/main/res/menu/menu_playlist_sort.xml b/app/src/main/res/menu/menu_playlist_sort.xml deleted file mode 100644 index 167fae26b..000000000 --- a/app/src/main/res/menu/menu_playlist_sort.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/values-be/strings.xml b/app/src/main/res/values-be/strings.xml index c8701ec78..833d8340e 100644 --- a/app/src/main/res/values-be/strings.xml +++ b/app/src/main/res/values-be/strings.xml @@ -274,7 +274,6 @@ Вокладка плэйліст для %s Плэйліст Плэйлісты - Адкл. Стварыце новы плэйліст Плэйліст %d Новы плэйліст diff --git a/app/src/main/res/values-cs/strings.xml b/app/src/main/res/values-cs/strings.xml index 912c15502..900a8e440 100644 --- a/app/src/main/res/values-cs/strings.xml +++ b/app/src/main/res/values-cs/strings.xml @@ -285,7 +285,6 @@ Seznam skladeb Při řazení ignorovat předložky Ignorovat slova jako „the“ při řazení podle názvu (funguje nejlépe u hudby v angličtině) - Žádné Vytvořit nový playlist Přidat do seznamu skladeb Přidáno do seznamu skladeb diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index e52fc3132..72c42e4a7 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -276,7 +276,6 @@ Wiedergabelisten Artikel beim Sortieren ignorieren Wörter wie „the“ ignorieren (funktioniert am besten mit englischsprachiger Musik) - Keine Neue Wiedergabeliste erstellen Neue Wiedergabeliste Zur Wiedergabeliste hinzugefügt diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index adcafbaf7..de9f77187 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -278,7 +278,6 @@ Listas de reproducción Imagen de la lista de reproducción para %s Lista de reproducción - Ninguno Ignorar artículos al ordenar Ignorar palabras como \"the\" al ordenar por nombre (funciona mejor con música en inglés) Crear una nueva lista de reproducción diff --git a/app/src/main/res/values-fi/strings.xml b/app/src/main/res/values-fi/strings.xml index 60578993e..85ff6f8e5 100644 --- a/app/src/main/res/values-fi/strings.xml +++ b/app/src/main/res/values-fi/strings.xml @@ -28,7 +28,6 @@ Etsi Suodata Kaikki - Ei mitään Nimi Kappalemäärä Levy diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index fe01d0302..353726d0a 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -206,7 +206,6 @@ Lecture Persistance Vider l\'état de lecture - Aucun Toujours commencer la lecture lorsqu\'un périphérique audio est connecté (pourrait ne pas fonctionner sur tous les appareils) Stratégie de normalisation de volume Par chanson diff --git a/app/src/main/res/values-gl/strings.xml b/app/src/main/res/values-gl/strings.xml index a74b4072e..022bca385 100644 --- a/app/src/main/res/values-gl/strings.xml +++ b/app/src/main/res/values-gl/strings.xml @@ -268,5 +268,4 @@ Imaxe da lista de reprodución para %s ampersand ganancia da repetición - Ningún \ No newline at end of file diff --git a/app/src/main/res/values-hr/strings.xml b/app/src/main/res/values-hr/strings.xml index 698bb0aa4..783f6f805 100644 --- a/app/src/main/res/values-hr/strings.xml +++ b/app/src/main/res/values-hr/strings.xml @@ -269,7 +269,6 @@ Glazba Slika popisa pjesama za %s Ponašanje - Ništa Pametno razvrstavanje Ispravno razvrstaj imena koja počinju brojevima ili riječima poput „the” (najbolje radi s glazbom na engleskom jeziku) Stvori novi popis pjesama diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index d9fa1243e..19d059cd1 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -287,5 +287,4 @@ Aggiunto alla playlist Niente canzoni Playlist %d - Nessuno \ No newline at end of file diff --git a/app/src/main/res/values-ja/strings.xml b/app/src/main/res/values-ja/strings.xml index 3670dcba1..62b5683b4 100644 --- a/app/src/main/res/values-ja/strings.xml +++ b/app/src/main/res/values-ja/strings.xml @@ -265,7 +265,6 @@ プレイリスト プレイリスト %s のプレイリスト イメージ - 無し 新規プレイリスト プレイリストに追加する プレイリストが作成されました diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml index fd54b0717..c99c87e16 100644 --- a/app/src/main/res/values-ko/strings.xml +++ b/app/src/main/res/values-ko/strings.xml @@ -276,7 +276,6 @@ %s의 재생 목록 이미지 정렬할 때 기사 무시 이름으로 정렬할 때 \"the\"와 같은 단어 무시(영어 음악에서 가장 잘 작동함) - 없음 새 재생 목록 만들기 새 재생목록 재생목록에 추가 diff --git a/app/src/main/res/values-lt/strings.xml b/app/src/main/res/values-lt/strings.xml index 4c1eb493a..9cc1f6ec5 100644 --- a/app/src/main/res/values-lt/strings.xml +++ b/app/src/main/res/values-lt/strings.xml @@ -274,6 +274,5 @@ Grojaraštis Grojaraščiai Grojaraščio vaizdas %s - Jokios Sukurti naują grojaraštį \ No newline at end of file diff --git a/app/src/main/res/values-ml/strings.xml b/app/src/main/res/values-ml/strings.xml index 0ecf86df0..fd2f7d19c 100644 --- a/app/src/main/res/values-ml/strings.xml +++ b/app/src/main/res/values-ml/strings.xml @@ -90,7 +90,6 @@ കലാകാരനിലേക്ക് പോകുക സവിശേഷതകൾ കാണുക സ്ഥിതി സംരക്ഷിച്ചു - ഒന്നുമില്ല അവരോഹണം സ്ഥിതി പുനഃസ്ഥാപിച്ചു വിക്കി diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml index 5754e7e38..c835f1de5 100644 --- a/app/src/main/res/values-pl/strings.xml +++ b/app/src/main/res/values-pl/strings.xml @@ -281,7 +281,6 @@ Obraz playlisty %s Inteligentne sortowanie Ignoruj słowa takie jak „the” oraz numery w tytule podczas sortowania (działa najlepiej z utworami w języku angielskim) - Brak Utwórz nową playlistę Nowa playlista Dodaj do playlisty diff --git a/app/src/main/res/values-ro/strings.xml b/app/src/main/res/values-ro/strings.xml index b99bc7023..1ef092e66 100644 --- a/app/src/main/res/values-ro/strings.xml +++ b/app/src/main/res/values-ro/strings.xml @@ -142,7 +142,6 @@ Treceți la următoarea Redă de la artist Redă din genul - Nu există Resetează Wiki Vizualizați și controlați redarea muzicii diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 072da2d2d..449dc9662 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -283,7 +283,6 @@ Обложка плейлиста для %s Игнорировать артикли при сортировке Игнорировать такие слова, как «the», при сортировке по имени (лучше всего работает с англоязычной музыкой) - Откл. Создать новый плейлист Новый плейлист Плейлист %d diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index c73aa22c3..db0b15c59 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -274,6 +274,5 @@ çalma listeleri Sıralama yaparken makaleleri yoksay Ada göre sıralarken \"the\" gibi kelimeleri yok sayın (en iyi ingilizce müzikle çalışır) - Hiçbiri Yeni bir oynatma listesi oluştur \ No newline at end of file diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index c7f387bc4..e29bd03a1 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -278,7 +278,6 @@ Зображення списку відтворення для %s Список відтворення Списки відтворення - Немає Інтелектуальне сортування Ігнорування таких слів, як \"the\", або цифр під час сортування за назвою (найкраще працює з англомовною музикою) Створити новий список відтворення diff --git a/app/src/main/res/values-zh-rCN/strings.xml b/app/src/main/res/values-zh-rCN/strings.xml index 1020ae1eb..60ff2a42b 100644 --- a/app/src/main/res/values-zh-rCN/strings.xml +++ b/app/src/main/res/values-zh-rCN/strings.xml @@ -272,7 +272,6 @@ 播放列表 播放列表 %s 的播放列表图片 - 排序时忽略冠词 按名称排序时忽略类似“the”这样的冠词(对英文歌曲的效果最好) 创建新的播放列表 diff --git a/app/src/main/res/values/settings.xml b/app/src/main/res/values/settings.xml index e9e9d5f2b..faab5d5cd 100644 --- a/app/src/main/res/values/settings.xml +++ b/app/src/main/res/values/settings.xml @@ -52,7 +52,6 @@ auxio_album_sort auxio_artist_sort auxio_genre_sort - auxio_playlist_sort @string/set_theme_auto diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 0eca031c4..bf01fa3dd 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -92,7 +92,6 @@ All - None Name Date Duration