From 787a78f845de2d31aed24a80576fda14f18a156c Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Mon, 23 Dec 2024 10:46:53 -0500 Subject: [PATCH] musikr: shrink end taglib jni size Use some magic linker flags that @Tolriq found over in https://github.com/taglib/taglib/issues/1212#issuecomment-2326456903 that somehow reduced linked so size by ~2mb. --- musikr/src/main/cpp/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/musikr/src/main/cpp/CMakeLists.txt b/musikr/src/main/cpp/CMakeLists.txt index b4df33f6c..82fbcd129 100644 --- a/musikr/src/main/cpp/CMakeLists.txt +++ b/musikr/src/main/cpp/CMakeLists.txt @@ -50,6 +50,12 @@ add_library(${CMAKE_PROJECT_NAME} SHARED JVMTagMap.cpp JVMMetadataBuilder.cpp ) +set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES + # @Tolriq found that these flags can reduce the size of the linked + # taglib + jni shim shared library. Kudos to them. + # https://github.com/taglib/taglib/issues/1212#issuecomment-2326456903 + LINK_FLAGS + "-Wl,--exclude-libs,ALL") # Specifies libraries CMake should link to your target library. You # can link libraries from various origins, such as libraries defined in this