diff --git a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackFragment.kt b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackFragment.kt index 2eecf4684..127e14d24 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/PlaybackFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/PlaybackFragment.kt @@ -88,7 +88,10 @@ class PlaybackFragment : Fragment(), SeekBar.OnSeekBarChangeListener { // Make marquee of song title work binding.playbackSong.isSelected = true - binding.playbackSeekBar.setOnSeekBarChangeListener(this) + binding.playbackSeekBar.apply { + setOnSeekBarChangeListener(this@PlaybackFragment) + isEnabled = true + } // --- VIEWMODEL SETUP -- diff --git a/app/src/main/java/org/oxycblt/auxio/settings/IntListPrefDialog.kt b/app/src/main/java/org/oxycblt/auxio/settings/IntListPrefDialog.kt index ee24d82b2..ac27289f4 100644 --- a/app/src/main/java/org/oxycblt/auxio/settings/IntListPrefDialog.kt +++ b/app/src/main/java/org/oxycblt/auxio/settings/IntListPrefDialog.kt @@ -18,12 +18,38 @@ package org.oxycblt.auxio.settings +import android.util.TypedValue import androidx.appcompat.app.AlertDialog +import androidx.appcompat.widget.AppCompatTextView +import androidx.core.content.res.ResourcesCompat +import androidx.core.view.updatePadding +import org.oxycblt.auxio.BuildConfig +import org.oxycblt.auxio.R import org.oxycblt.auxio.ui.LifecycleDialog +import org.oxycblt.auxio.util.resolveAttr class IntListPrefDialog(private val pref: IntListPreference) : LifecycleDialog() { override fun onConfigDialog(builder: AlertDialog.Builder) { - builder.setTitle(pref.title) + // Don't set the title. Instead. Set a custom title view so that the padding actually + // works between the title and this dialog's contents. I can't believe I have to do this. + val titleView = AppCompatTextView(requireContext()).apply { + text = pref.title + typeface = ResourcesCompat.getFont(context, R.font.inter_bold) + setTextSize( + TypedValue.COMPLEX_UNIT_PX, + resources.getDimensionPixelSize(R.dimen.text_size_large).toFloat() + ) + setTextColor(android.R.attr.textColorPrimary.resolveAttr(context)) + + // We have to make the bottom padding account for the ListView's immutable top padding, + // because Android's dialog code is a massive pile of broken spaghetti. + val padding = resources.getDimension(R.dimen.spacing_medium).toInt() + val paddingHack = resources.getDimension(R.dimen.spacing_small).toInt() + + updatePadding(left = padding, top = padding, right = padding, bottom = paddingHack) + } + + builder.setCustomTitle(titleView) builder.setSingleChoiceItems(pref.entries, pref.getValueIndex()) { _, index -> pref.setValueIndex(index) @@ -35,6 +61,6 @@ class IntListPrefDialog(private val pref: IntListPreference) : LifecycleDialog() } companion object { - const val TAG = "TAG_INT_PREF_DIALOG" + const val TAG = BuildConfig.APPLICATION_ID + ".tag.INT_PREF" } } diff --git a/app/src/main/res/color/overlay_popup.xml b/app/src/main/res/color/overlay_popup.xml index e35a1a916..beffdd9c0 100644 --- a/app/src/main/res/color/overlay_popup.xml +++ b/app/src/main/res/color/overlay_popup.xml @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/src/main/res/color-night/overlay_popup.xml b/app/src/main/res/color/overlay_seekbar_halo.xml similarity index 62% rename from app/src/main/res/color-night/overlay_popup.xml rename to app/src/main/res/color/overlay_seekbar_halo.xml index dcc7baad3..afbfb0dc9 100644 --- a/app/src/main/res/color-night/overlay_popup.xml +++ b/app/src/main/res/color/overlay_seekbar_halo.xml @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/src/main/res/layout/dialog_accent.xml b/app/src/main/res/layout/dialog_accent.xml index 41afa5b64..08b3fef5b 100644 --- a/app/src/main/res/layout/dialog_accent.xml +++ b/app/src/main/res/layout/dialog_accent.xml @@ -8,7 +8,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:overScrollMode="never" - android:paddingTop="@dimen/spacing_small" + android:paddingTop="@dimen/spacing_medium" app:layoutManager="org.oxycblt.auxio.accent.AutoGridLayoutManager" app:layout_constraintBottom_toTopOf="@+id/accent_cancel" app:layout_constraintTop_toBottomOf="@+id/accent_header" diff --git a/app/src/main/res/layout/dialog_excluded.xml b/app/src/main/res/layout/dialog_excluded.xml index 2ba0fba5b..f8d4995ca 100644 --- a/app/src/main/res/layout/dialog_excluded.xml +++ b/app/src/main/res/layout/dialog_excluded.xml @@ -7,7 +7,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingTop="@dimen/spacing_small"> + android:paddingTop="@dimen/spacing_medium"> + \ No newline at end of file diff --git a/app/src/main/res/layout/item_excluded_dir.xml b/app/src/main/res/layout/item_excluded_dir.xml index 10ecbf1f1..ccc53ffa2 100644 --- a/app/src/main/res/layout/item_excluded_dir.xml +++ b/app/src/main/res/layout/item_excluded_dir.xml @@ -5,13 +5,14 @@ diff --git a/app/src/main/res/values-night/styles_core.xml b/app/src/main/res/values-night/styles_core.xml new file mode 100644 index 000000000..04a85d41c --- /dev/null +++ b/app/src/main/res/values-night/styles_core.xml @@ -0,0 +1,12 @@ + + + + \ No newline at end of file diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index c5fbbfa58..e3c28fd55 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -37,4 +37,6 @@ 8dp 4dp + + 0dp \ No newline at end of file diff --git a/app/src/main/res/values/styles_android.xml b/app/src/main/res/values/styles_android.xml index 4588bfbf6..59819c7b9 100644 --- a/app/src/main/res/values/styles_android.xml +++ b/app/src/main/res/values/styles_android.xml @@ -5,7 +5,6 @@ @@ -15,46 +14,22 @@ @color/overlay_selection - - - - - - - - - - - - - - @@ -71,7 +46,6 @@ @font/inter_semibold ?attr/colorAccent ?android:attr/textAppearanceButton - ?android:attr/colorControlHighlight 0dp diff --git a/app/src/main/res/values/styles_core.xml b/app/src/main/res/values/styles_core.xml index d8ce9d0b3..7f571ddb6 100644 --- a/app/src/main/res/values/styles_core.xml +++ b/app/src/main/res/values/styles_core.xml @@ -6,9 +6,14 @@ - + @color/overlay_seekbar_halo @@ -211,7 +219,7 @@