Revert "detail: fix up navigation"

This reverts commit bfdccd3ba5.

app/src/main/java/org/oxycblt/auxio/detail/AlbumDetailFragment.kt

@@ -106,7 +106,7 @@ class AlbumDetailFragment : DetailFragment<Album, Song>() {
     private fun updateAlbum(album: Album?) {
         if (album == null) {
             L.d("No album to show, navigating away")
-            exit()
+            findNavController().navigateUp()
             return
         }
 

app/src/main/java/org/oxycblt/auxio/detail/ArtistDetailFragment.kt

@@ -113,7 +113,7 @@ class ArtistDetailFragment : DetailFragment<Artist, Music>() {
     private fun updateArtist(artist: Artist?) {
         if (artist == null) {
             L.d("No artist to show, navigating away")
-            exit()
+            findNavController().navigateUp()
             return
         }
         val binding = requireBinding()

app/src/main/java/org/oxycblt/auxio/detail/DetailFragment.kt

@@ -22,7 +22,6 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import androidx.fragment.app.activityViewModels
 import androidx.navigation.findNavController
-import androidx.navigation.fragment.findNavController
 import androidx.recyclerview.widget.GridLayoutManager
 import com.google.android.material.appbar.AppBarLayout
 import com.google.android.material.transition.MaterialSharedAxis
@@ -130,11 +129,4 @@ abstract class DetailFragment<P : MusicParent, C : Music> :
     }
 
     abstract fun onOpenParentMenu()
-
-    protected fun exit() {
-        // For some insane and absurd reason we wont actually navigate away in detail views
-        // until this is called twice.
-        findNavController().navigateUp()
-        findNavController().navigateUp()
-    }
 }

app/src/main/java/org/oxycblt/auxio/detail/GenreDetailFragment.kt

@@ -112,7 +112,7 @@ class GenreDetailFragment : DetailFragment<Genre, Music>() {
     private fun updateGenre(genre: Genre?) {
         if (genre == null) {
             L.d("No genre to show, navigating away")
-            exit()
+            findNavController().navigateUp()
             return
         }
         val binding = requireBinding()

app/src/main/java/org/oxycblt/auxio/detail/PlaylistDetailFragment.kt

@@ -184,7 +184,8 @@ class PlaylistDetailFragment :
 
     private fun updatePlaylist(playlist: Playlist?, editedPlaylist: List<Song>?) {
         if (playlist == null) {
-            exit()
+            // Playlist we were showing no longer exists.
+            findNavController().navigateUp()
             return
         }
         val binding = requireBinding()