From 5861d1db87cb70aeaade498511d8c720d25c3f42 Mon Sep 17 00:00:00 2001
From: Alexander Capehart <alex@oxycblt.org>
Date: Thu, 13 Jun 2024 19:49:53 -0600
Subject: [PATCH] music: use both ogg/mp3 style mb tags at once

Apparently both can exist on both types of files, and grouping will
break as a result due to MBID mismatch.
---
 .../oxycblt/auxio/music/metadata/TagWorker.kt | 38 +++++++++++++------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/app/src/main/java/org/oxycblt/auxio/music/metadata/TagWorker.kt b/app/src/main/java/org/oxycblt/auxio/music/metadata/TagWorker.kt
index 202f364df..fe8ca0c46 100644
--- a/app/src/main/java/org/oxycblt/auxio/music/metadata/TagWorker.kt
+++ b/app/src/main/java/org/oxycblt/auxio/music/metadata/TagWorker.kt
@@ -140,7 +140,9 @@ private class TagWorkerImpl(
 
     private fun populateWithId3v2(textFrames: Map<String, List<String>>) {
         // Song
-        textFrames["TXXX:musicbrainz release track id"]?.let { rawSong.musicBrainzId = it.first() }
+        (textFrames["TXXX:musicbrainz release track id"]
+                ?: textFrames["TXXX:musicbrainz_releasetrackid"])
+            ?.let { rawSong.musicBrainzId = it.first() }
         textFrames["TIT2"]?.let { rawSong.name = it.first() }
         textFrames["TSOT"]?.let { rawSong.sortName = it.first() }
 
@@ -170,7 +172,9 @@ private class TagWorkerImpl(
             ?.let { rawSong.date = it }
 
         // Album
-        textFrames["TXXX:musicbrainz album id"]?.let { rawSong.albumMusicBrainzId = it.first() }
+        (textFrames["TXXX:musicbrainz album id"] ?: textFrames["TXXX:musicbrainz_albumid"])?.let {
+            rawSong.albumMusicBrainzId = it.first()
+        }
         textFrames["TALB"]?.let { rawSong.albumName = it.first() }
         textFrames["TSOA"]?.let { rawSong.albumSortName = it.first() }
         (textFrames["TXXX:musicbrainz album type"]
@@ -180,7 +184,9 @@ private class TagWorkerImpl(
             ?.let { rawSong.releaseTypes = it }
 
         // Artist
-        textFrames["TXXX:musicbrainz artist id"]?.let { rawSong.artistMusicBrainzIds = it }
+        (textFrames["TXXX:musicbrainz artist id"] ?: textFrames["TXXX:musicbrainz_artistid"])?.let {
+            rawSong.artistMusicBrainzIds = it
+        }
         (textFrames["TXXX:artists"] ?: textFrames["TPE1"])?.let { rawSong.artistNames = it }
         (textFrames["TXXX:artistssort"]
                 ?: textFrames["TXXX:artists_sort"] ?: textFrames["TXXX:artists sort"]
@@ -188,9 +194,9 @@ private class TagWorkerImpl(
             ?.let { rawSong.artistSortNames = it }
 
         // Album artist
-        textFrames["TXXX:musicbrainz album artist id"]?.let {
-            rawSong.albumArtistMusicBrainzIds = it
-        }
+        (textFrames["TXXX:musicbrainz album artist id"]
+                ?: textFrames["TXXX:musicbrainz_albumartistid"])
+            ?.let { rawSong.albumArtistMusicBrainzIds = it }
         (textFrames["TXXX:albumartists"]
                 ?: textFrames["TXXX:album_artists"] ?: textFrames["TXXX:album artists"]
                     ?: textFrames["TPE2"])
@@ -261,7 +267,9 @@ private class TagWorkerImpl(
 
     private fun populateWithVorbis(comments: Map<String, List<String>>) {
         // Song
-        comments["musicbrainz_releasetrackid"]?.let { rawSong.musicBrainzId = it.first() }
+        (comments["musicbrainz_releasetrackid"] ?: comments["musicbrainz release track id"])?.let {
+            rawSong.musicBrainzId = it.first()
+        }
         comments["title"]?.let { rawSong.name = it.first() }
         comments["titlesort"]?.let { rawSong.sortName = it.first() }
 
@@ -290,20 +298,28 @@ private class TagWorkerImpl(
             ?.let { rawSong.date = it }
 
         // Album
-        comments["musicbrainz_albumid"]?.let { rawSong.albumMusicBrainzId = it.first() }
+        (comments["musicbrainz_albumid"] ?: comments["musicbrainz album id"])?.let {
+            rawSong.albumMusicBrainzId = it.first()
+        }
         comments["album"]?.let { rawSong.albumName = it.first() }
         comments["albumsort"]?.let { rawSong.albumSortName = it.first() }
-        comments["releasetype"]?.let { rawSong.releaseTypes = it }
+        (comments["releasetype"] ?: comments["musicbrainz album type"])?.let {
+            rawSong.releaseTypes = it
+        }
 
         // Artist
-        comments["musicbrainz_artistid"]?.let { rawSong.artistMusicBrainzIds = it }
+        (comments["musicbrainz_artistid"] ?: comments["musicbrainz artist id"])?.let {
+            rawSong.artistMusicBrainzIds = it
+        }
         (comments["artists"] ?: comments["artist"])?.let { rawSong.artistNames = it }
         (comments["artistssort"]
                 ?: comments["artists_sort"] ?: comments["artists sort"] ?: comments["artistsort"])
             ?.let { rawSong.artistSortNames = it }
 
         // Album artist
-        comments["musicbrainz_albumartistid"]?.let { rawSong.albumArtistMusicBrainzIds = it }
+        (comments["musicbrainz_albumartistid"] ?: comments["musicbrainz album artist id"])?.let {
+            rawSong.albumArtistMusicBrainzIds = it
+        }
         (comments["albumartists"]
                 ?: comments["album_artists"] ?: comments["album artists"]
                     ?: comments["albumartist"])