From 443c26fe9849dbca8ed792d859e77a923db99bd5 Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Tue, 14 Sep 2021 20:16:55 -0600 Subject: [PATCH] styles: refactor style methodology Refactor the styling again to make all styles start with the Auxio prefix. Also try to phase out the usage of layout_width and layout_height in most places, since those can cause a lot of frustration if they aren't used in the layout they are expected in. --- app/src/main/AndroidManifest.xml | 2 +- .../java/org/oxycblt/auxio/accent/Accent.kt | 46 +++--- .../system/PlaybackSessionConnector.kt | 3 - .../auxio/settings/IntListPrefDialog.kt | 2 +- .../java/org/oxycblt/auxio/ui/DisplayMode.kt | 2 +- .../res/layout-land/fragment_playback.xml | 44 ++++-- app/src/main/res/layout-land/item_detail.xml | 16 ++- app/src/main/res/layout-large/item_detail.xml | 20 +-- .../layout-xlarge-land/fragment_playback.xml | 44 ++++-- .../res/layout-xlarge/fragment_playback.xml | 48 +++++-- app/src/main/res/layout/fragment_about.xml | 29 ++-- .../res/layout/fragment_compact_playback.xml | 18 ++- app/src/main/res/layout/fragment_detail.xml | 2 +- app/src/main/res/layout/fragment_home.xml | 4 +- app/src/main/res/layout/fragment_loading.xml | 2 +- app/src/main/res/layout/fragment_playback.xml | 46 ++++-- app/src/main/res/layout/fragment_queue.xml | 2 +- app/src/main/res/layout/fragment_search.xml | 2 +- app/src/main/res/layout/fragment_settings.xml | 2 +- .../main/res/layout/item_action_header.xml | 11 +- app/src/main/res/layout/item_album.xml | 12 +- app/src/main/res/layout/item_album_song.xml | 12 +- app/src/main/res/layout/item_artist.xml | 12 +- app/src/main/res/layout/item_artist_album.xml | 12 +- app/src/main/res/layout/item_artist_song.xml | 18 ++- app/src/main/res/layout/item_detail.xml | 16 ++- app/src/main/res/layout/item_excluded_dir.xml | 22 +-- app/src/main/res/layout/item_genre.xml | 12 +- app/src/main/res/layout/item_genre_song.xml | 18 ++- app/src/main/res/layout/item_header.xml | 4 +- app/src/main/res/layout/item_queue_song.xml | 20 ++- app/src/main/res/layout/item_song.xml | 12 +- app/src/main/res/layout/widget_full.xml | 40 ++++-- app/src/main/res/layout/widget_small.xml | 30 +++- .../main/res/values-night-v27/styles_core.xml | 2 +- app/src/main/res/values-night/styles_core.xml | 2 +- app/src/main/res/values-v27/styles_core.xml | 2 +- .../main/res/values-v31/styles_android.xml | 6 + .../main/res/values-v31/styles_component.xml | 8 -- app/src/main/res/values-v31/styles_core.xml | 2 +- app/src/main/res/values/styles_android.xml | 67 +++++++-- app/src/main/res/values/styles_component.xml | 76 ---------- app/src/main/res/values/styles_core.xml | 20 +-- app/src/main/res/values/styles_ui.xml | 132 ++++++++---------- app/src/main/res/values/themes.xml | 40 +++--- app/src/main/res/values/themes_black.xml | 36 ++--- info/ARCHITECTURE.md | 18 +-- 47 files changed, 568 insertions(+), 428 deletions(-) create mode 100644 app/src/main/res/values-v31/styles_android.xml delete mode 100644 app/src/main/res/values-v31/styles_component.xml delete mode 100644 app/src/main/res/values/styles_component.xml diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index ebacc8d9a..becb161fe 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -22,7 +22,7 @@ android:label="@string/info_app_name" android:roundIcon="@mipmap/ic_launcher_round" android:supportsRtl="true" - android:theme="@style/Theme.Base"> + android:theme="@style/Theme.Auxio.App"> CONST_SHOW_SONGS diff --git a/app/src/main/res/layout-land/fragment_playback.xml b/app/src/main/res/layout-land/fragment_playback.xml index ba7929c66..ca528b3e1 100644 --- a/app/src/main/res/layout-land/fragment_playback.xml +++ b/app/src/main/res/layout-land/fragment_playback.xml @@ -28,7 +28,7 @@ + app:layout_constraintTop_toTopOf="@+id/playback_skip_next" + app:tint="@color/sel_accented" /> \ No newline at end of file diff --git a/app/src/main/res/layout-land/item_detail.xml b/app/src/main/res/layout-land/item_detail.xml index 36eae3636..87989341e 100644 --- a/app/src/main/res/layout-land/item_detail.xml +++ b/app/src/main/res/layout-land/item_detail.xml @@ -12,17 +12,17 @@ + tools:ignore="ContentDescription" + tools:src="@drawable/ic_artist" /> + tools:ignore="ContentDescription" + tools:src="@drawable/ic_artist" /> + app:layout_constraintTop_toTopOf="@+id/playback_skip_next" + app:tint="@color/sel_accented" /> \ No newline at end of file diff --git a/app/src/main/res/layout-xlarge/fragment_playback.xml b/app/src/main/res/layout-xlarge/fragment_playback.xml index 510c14b6e..96a60fc7a 100644 --- a/app/src/main/res/layout-xlarge/fragment_playback.xml +++ b/app/src/main/res/layout-xlarge/fragment_playback.xml @@ -28,7 +28,7 @@ + app:layout_constraintTop_toTopOf="@+id/playback_skip_next" + app:tint="@color/sel_accented" /> diff --git a/app/src/main/res/layout/fragment_about.xml b/app/src/main/res/layout/fragment_about.xml index d94a1ee30..5a0f4035c 100644 --- a/app/src/main/res/layout/fragment_about.xml +++ b/app/src/main/res/layout/fragment_about.xml @@ -19,7 +19,7 @@ @@ -29,7 +29,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:clipToPadding="false" - android:theme="@style/Theme.Neutral" app:layout_behavior="com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior"> @@ -129,7 +128,9 @@ + style="@style/Widget.Auxio.Toolbar.Icon" /> diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index 3a520281e..81ed7122a 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -23,7 +23,7 @@ @@ -36,7 +36,7 @@ app:tabContentStart="@dimen/spacing_medium" app:tabIndicatorColor="?attr/colorAccent" app:tabMode="scrollable" - app:tabTextAppearance="@style/TextAppearance.TabLayout.Label" + app:tabTextAppearance="@style/TextAppearance.Auxio.TabLayout.Label" app:tabTextColor="?android:attr/textColorPrimary" app:tabUnboundedRipple="true" /> diff --git a/app/src/main/res/layout/fragment_loading.xml b/app/src/main/res/layout/fragment_loading.xml index f9a366e64..cb23b5727 100644 --- a/app/src/main/res/layout/fragment_loading.xml +++ b/app/src/main/res/layout/fragment_loading.xml @@ -48,7 +48,7 @@ + app:layout_constraintTop_toTopOf="@+id/playback_skip_next" + app:tint="@color/sel_accented" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_queue.xml b/app/src/main/res/layout/fragment_queue.xml index 619098f3c..13394d1a5 100644 --- a/app/src/main/res/layout/fragment_queue.xml +++ b/app/src/main/res/layout/fragment_queue.xml @@ -22,7 +22,7 @@ diff --git a/app/src/main/res/layout/fragment_search.xml b/app/src/main/res/layout/fragment_search.xml index 665d4a1d0..544bd6898 100644 --- a/app/src/main/res/layout/fragment_search.xml +++ b/app/src/main/res/layout/fragment_search.xml @@ -17,7 +17,7 @@ diff --git a/app/src/main/res/layout/fragment_settings.xml b/app/src/main/res/layout/fragment_settings.xml index 620bf4f37..cc143287f 100644 --- a/app/src/main/res/layout/fragment_settings.xml +++ b/app/src/main/res/layout/fragment_settings.xml @@ -22,7 +22,7 @@ diff --git a/app/src/main/res/layout/item_action_header.xml b/app/src/main/res/layout/item_action_header.xml index 89e6dd5c1..d1f39eeb5 100644 --- a/app/src/main/res/layout/item_action_header.xml +++ b/app/src/main/res/layout/item_action_header.xml @@ -17,7 +17,7 @@ + tools:src="@drawable/ic_sort" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_album.xml b/app/src/main/res/layout/item_album.xml index 05e9ea78d..2c3b89fba 100644 --- a/app/src/main/res/layout/item_album.xml +++ b/app/src/main/res/layout/item_album.xml @@ -11,11 +11,11 @@ type="org.oxycblt.auxio.music.Album" /> - + - + - + - + - + + tools:ignore="ContentDescription" + tools:src="@drawable/ic_artist" /> + android:focusable="false" + android:padding="0dp"> + app:layout_constraintTop_toTopOf="parent" + app:tint="?attr/colorControlNormal" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_genre.xml b/app/src/main/res/layout/item_genre.xml index c01e67147..086ab918b 100644 --- a/app/src/main/res/layout/item_genre.xml +++ b/app/src/main/res/layout/item_genre.xml @@ -11,11 +11,11 @@ type="org.oxycblt.auxio.music.Genre" /> - + - + \ No newline at end of file diff --git a/app/src/main/res/layout/item_queue_song.xml b/app/src/main/res/layout/item_queue_song.xml index fcc327bb4..ea8b27042 100644 --- a/app/src/main/res/layout/item_queue_song.xml +++ b/app/src/main/res/layout/item_queue_song.xml @@ -18,10 +18,10 @@ - + - + diff --git a/app/src/main/res/layout/widget_small.xml b/app/src/main/res/layout/widget_small.xml index 480f70072..870ad7075 100644 --- a/app/src/main/res/layout/widget_small.xml +++ b/app/src/main/res/layout/widget_small.xml @@ -8,20 +8,27 @@ - + diff --git a/app/src/main/res/values-night-v27/styles_core.xml b/app/src/main/res/values-night-v27/styles_core.xml index 4dc7dc273..60568bbe6 100644 --- a/app/src/main/res/values-night-v27/styles_core.xml +++ b/app/src/main/res/values-night-v27/styles_core.xml @@ -1,7 +1,7 @@ - + \ No newline at end of file diff --git a/app/src/main/res/values-v31/styles_component.xml b/app/src/main/res/values-v31/styles_component.xml deleted file mode 100644 index efb0ce40a..000000000 --- a/app/src/main/res/values-v31/styles_component.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - - diff --git a/app/src/main/res/values/styles_android.xml b/app/src/main/res/values/styles_android.xml index 58c1625b8..ca55b2203 100644 --- a/app/src/main/res/values/styles_android.xml +++ b/app/src/main/res/values/styles_android.xml @@ -3,31 +3,31 @@ - - - - - + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/values/styles_component.xml b/app/src/main/res/values/styles_component.xml deleted file mode 100644 index 430e6a7a5..000000000 --- a/app/src/main/res/values/styles_component.xml +++ /dev/null @@ -1,76 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - @@ -55,5 +59,5 @@ Theming widgets is technically possible below Android 12, but I *really* don't care enough to bother with it. --> - - - - + + - - - - - - - - - - - + + - - - - - - - - - - - - - - - - - - + + \ No newline at end of file diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index a6256c50f..7c732e1fa 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -2,82 +2,80 @@ - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/values/themes_black.xml b/app/src/main/res/values/themes_black.xml index 799f5b5cd..2e5fbf940 100644 --- a/app/src/main/res/values/themes_black.xml +++ b/app/src/main/res/values/themes_black.xml @@ -3,75 +3,75 @@ - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/info/ARCHITECTURE.md b/info/ARCHITECTURE.md index 8dd7b281e..1c57ddf3a 100644 --- a/info/ARCHITECTURE.md +++ b/info/ARCHITECTURE.md @@ -47,15 +47,15 @@ To prevent any strange bugs, all integer representations must be unique. A table 0xA004 | HeaderViewHolder 0xA005 | ActionHeaderViewHolder -0xA005 | AlbumDetailViewHolder -0xA006 | AlbumSongViewHolder -0xA007 | ArtistDetailViewHolder -0xA008 | ArtistAlbumViewHolder -0xA009 | ArtistSongViewHolder -0xA010 | GenreDetailViewHolder -0xA011 | GenreSongViewHolder +0xA006 | AlbumDetailViewHolder +0xA007 | AlbumSongViewHolder +0xA008 | ArtistDetailViewHolder +0xA009 | ArtistAlbumViewHolder +0xA00A | ArtistSongViewHolder +0xA00B | GenreDetailViewHolder +0xA00C | GenreSongViewHolder -0xA00A | QueueSongViewHolder +0xA00D | QueueSongViewHolder 0xA0A0 | Auxio notification code 0xA0C0 | Auxio request code @@ -71,7 +71,7 @@ To prevent any strange bugs, all integer representations must be unique. A table 0xA105 | PlaybackMode.IN_ALBUM 0xA106 | PlaybackMode.ALL_SONGS -0xA107 | DisplayMode.SHOW_ALL +0xA107 | Null DisplayMode [Filter Nothing] 0xA108 | DisplayMode.SHOW_GENRES 0xA109 | DisplayMode.SHOW_ARTISTS 0xA10A | DisplayMode.SHOW_ALBUMS