Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

all: fix db memory leak

Browse source 
Fix an issue where the database instances would leak memory due to an
incorrect context use.
This commit is contained in:
Alexander Capehart 2023-01-29 19:22:31 -07:00
parent 2413edfd5e
commit 4012c35cf4
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
3 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/org/oxycblt/auxio/music/extractor/CacheExtractor.kt
View file

@ -187,7 +187,9 @@ private abstract class CacheDatabase : RoomDatabase() {
synchronized(this) { synchronized(this) {
val newInstance = val newInstance =
Room.databaseBuilder( Room.databaseBuilder(
context, CacheDatabase::class.java, "auxio_metadata_cache.db") context.applicationContext,
CacheDatabase::class.java,
"auxio_metadata_cache.db")
.fallbackToDestructiveMigration() .fallbackToDestructiveMigration()
.fallbackToDestructiveMigrationFrom(0) .fallbackToDestructiveMigrationFrom(0)
.fallbackToDestructiveMigrationOnDowngrade() .fallbackToDestructiveMigrationOnDowngrade()

2
app/src/main/java/org/oxycblt/auxio/playback/persist/PersistenceDatabase.kt
View file

@ -69,7 +69,7 @@ abstract class PersistenceDatabase : RoomDatabase() {
synchronized(this) { synchronized(this) {
val newInstance = val newInstance =
Room.databaseBuilder( Room.databaseBuilder(
context, context.applicationContext,
PersistenceDatabase::class.java, PersistenceDatabase::class.java,
"auxio_playback_persistence.db") "auxio_playback_persistence.db")
.fallbackToDestructiveMigration() .fallbackToDestructiveMigration()

2
app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackStateManager.kt
View file

@ -280,6 +280,7 @@ interface PlaybackStateManager {
*/ */
fun get(): PlaybackStateManager { fun get(): PlaybackStateManager {
val currentInstance = INSTANCE val currentInstance = INSTANCE
logD(currentInstance)
if (currentInstance != null) { if (currentInstance != null) {
return currentInstance return currentInstance
@ -553,6 +554,7 @@ private class RealPlaybackStateManager : PlaybackStateManager {
// Internal player may have reloaded the media item, re-seek to the previous position // Internal player may have reloaded the media item, re-seek to the previous position
seekTo(savedState.positionMs) seekTo(savedState.positionMs)
} }
isInitialized = true
} }
// --- CALLBACKS --- // --- CALLBACKS ---