Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

playback: use more efficient no-op w/replaygain

Browse source 
When ReplayGain is not needed, use ByteBuffer.put in favor of a for
loop when doing a simple copy.

ByteBuffer.put is highly optimized and far more efficient than a for
loop.
This commit is contained in:
OxygenCobalt 2022-06-11 09:27:55 -06:00
parent d42f5970f1
commit 277e5a151f
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/org/oxycblt/auxio/playback/replaygain/ReplayGainAudioProcessor.kt
View file

@ -226,10 +226,9 @@ class ReplayGainAudioProcessor : BaseAudioProcessor() {
val buffer = replaceOutputBuffer(size) val buffer = replaceOutputBuffer(size)
if (volume == 1f) { if (volume == 1f) {
// Nothing to do, just copy the bytes into the output buffer. // No need to apply ReplayGain, do a memmove using put instead of
for (i in position until limit) { // a for loop (the latter is not efficient)
buffer.put(inputBuffer[i]) buffer.put(inputBuffer.slice())
}
} else { } else {
for (i in position until limit step 2) { for (i in position until limit step 2) {
// Ensure we clamp the values to the minimum and maximum values possible // Ensure we clamp the values to the minimum and maximum values possible