From 1d1da1fac2768a5fb60b790a58d0996b7ab79711 Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Wed, 17 Feb 2021 10:39:15 -0700 Subject: [PATCH] Update exoplayer Bump exoplayer to 2.12.3 --- app/build.gradle | 4 ++-- .../java/org/oxycblt/auxio/playback/PlayPauseButton.kt | 4 ++++ app/src/main/res/drawable/ic_play_large.xml | 8 ++++---- app/src/main/res/menu/menu_library.xml | 2 +- fastlane/metadata/android/en-US/changelogs/1.txt | 4 ++-- 5 files changed, 13 insertions(+), 9 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index b48425c81..fde47b762 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -12,7 +12,7 @@ android { minSdkVersion 21 targetSdkVersion 30 versionCode 2 // Code 1 officially responds to 1.2, anything higher is 1.3 onwards - versionName "1.2.0" + versionName "1.3.0" buildFeatures { dataBinding true @@ -89,7 +89,7 @@ dependencies { // --- THIRD PARTY --- // ExoPlayer - def exoplayer_version = "2.12.1" + def exoplayer_version = "2.12.3" implementation "com.google.android.exoplayer:exoplayer-core:$exoplayer_version" implementation "com.google.android.exoplayer:extension-mediasession:$exoplayer_version" diff --git a/app/src/main/java/org/oxycblt/auxio/playback/PlayPauseButton.kt b/app/src/main/java/org/oxycblt/auxio/playback/PlayPauseButton.kt index 8473839ab..8efb47da7 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/PlayPauseButton.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/PlayPauseButton.kt @@ -45,6 +45,10 @@ class PlayPauseButton @JvmOverloads constructor( } } + /** + * Hack that fixes an issue where a seam would display in the middle of the play button, + * probably as a result of floating point precision errors. Gotta love IEEE 754. + */ @RequiresApi(Build.VERSION_CODES.M) private fun fixSeams() { iconPauseToPlay.registerAnimationCallback(object : Animatable2.AnimationCallback() { diff --git a/app/src/main/res/drawable/ic_play_large.xml b/app/src/main/res/drawable/ic_play_large.xml index d4a3e0b50..029c479e7 100644 --- a/app/src/main/res/drawable/ic_play_large.xml +++ b/app/src/main/res/drawable/ic_play_large.xml @@ -19,14 +19,14 @@ + android:pathData="m 8.2501424,6.0001505 v 5.9996335 6.000151 L 18.749759,11.999784 Z" + android:strokeColor="#00000000" /> + android:pathData="m 8.2501424,6.0001505 v 5.9996335 6.000151 L 18.749759,11.999784 Z" + android:strokeColor="#00000000" /> diff --git a/app/src/main/res/menu/menu_library.xml b/app/src/main/res/menu/menu_library.xml index 4a371df9b..d057e6151 100644 --- a/app/src/main/res/menu/menu_library.xml +++ b/app/src/main/res/menu/menu_library.xml @@ -20,5 +20,5 @@ android:title="@string/label_sort_alpha_up" /> - - + \ No newline at end of file diff --git a/fastlane/metadata/android/en-US/changelogs/1.txt b/fastlane/metadata/android/en-US/changelogs/1.txt index a02623d42..a443dae23 100644 --- a/fastlane/metadata/android/en-US/changelogs/1.txt +++ b/fastlane/metadata/android/en-US/changelogs/1.txt @@ -4,6 +4,6 @@ - Added search filtering - Fixed issue where audio focus would resume playback when it shouldn't - Fixed crashes with song selection/startup -- Fixed issue where keyboard wouldnt disappear on search -- Fixed issue where rewinding wouldnt cause playback to start again +- Fixed issue where keyboard wouldn't disappear on search +- Fixed issue where rewinding wouldn't cause playback to start again - Artist play button now works again \ No newline at end of file