diff --git a/app/src/main/java/org/oxycblt/auxio/home/HomeFragment.kt b/app/src/main/java/org/oxycblt/auxio/home/HomeFragment.kt index c7b0df19a..a056e751b 100644 --- a/app/src/main/java/org/oxycblt/auxio/home/HomeFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/home/HomeFragment.kt @@ -75,12 +75,12 @@ class HomeFragment : ViewBindingFragment(), Toolbar.OnMenuI private val playbackModel: PlaybackViewModel by androidActivityViewModels() private val navModel: NavigationViewModel by activityViewModels() private val homeModel: HomeViewModel by androidActivityViewModels() - private val indexerModel: MusicViewModel by activityViewModels() + private val musicModel: MusicViewModel by activityViewModels() // lifecycleObject builds this in the creation step, so doing this is okay. private val storagePermissionLauncher: ActivityResultLauncher by lifecycleObject { registerForActivityResult(ActivityResultContracts.RequestPermission()) { - indexerModel.reindex() + musicModel.reindex() } } @@ -142,8 +142,8 @@ class HomeFragment : ViewBindingFragment(), Toolbar.OnMenuI collect(homeModel.recreateTabs, ::handleRecreateTabs) collectImmediately(homeModel.currentTab, ::updateCurrentTab) - collectImmediately(indexerModel.libraryExists, homeModel.isFastScrolling, ::updateFab) - collectImmediately(indexerModel.indexerState, ::handleIndexerState) + collectImmediately(musicModel.libraryExists, homeModel.isFastScrolling, ::updateFab) + collectImmediately(musicModel.indexerState, ::handleIndexerState) collect(navModel.exploreNavigationItem, ::handleNavigation) } @@ -283,7 +283,7 @@ class HomeFragment : ViewBindingFragment(), Toolbar.OnMenuI binding.homeIndexingAction.apply { visibility = View.VISIBLE text = getString(R.string.lbl_retry) - setOnClickListener { indexerModel.reindex() } + setOnClickListener { musicModel.reindex() } } } is Indexer.Response.NoMusic -> { @@ -292,7 +292,7 @@ class HomeFragment : ViewBindingFragment(), Toolbar.OnMenuI binding.homeIndexingAction.apply { visibility = View.VISIBLE text = getString(R.string.lbl_retry) - setOnClickListener { indexerModel.reindex() } + setOnClickListener { musicModel.reindex() } } } is Indexer.Response.NoPerms -> { diff --git a/app/src/main/java/org/oxycblt/auxio/music/system/IndexerService.kt b/app/src/main/java/org/oxycblt/auxio/music/system/IndexerService.kt index 27e3a6c66..daadab691 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/system/IndexerService.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/system/IndexerService.kt @@ -46,6 +46,8 @@ import org.oxycblt.auxio.util.logD * You could probably do the same using WorkManager and the GooberQueue library or whatever, but the * boilerplate you skip is not worth the insanity of androidx. * + * TODO: Add a wake-lock to the music loading process + * * @author OxygenCobalt */ class IndexerService : Service(), Indexer.Controller, Settings.Callback { diff --git a/app/src/main/java/org/oxycblt/auxio/playback/state/RepeatMode.kt b/app/src/main/java/org/oxycblt/auxio/playback/state/RepeatMode.kt index 9e8785181..97709897f 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/state/RepeatMode.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/state/RepeatMode.kt @@ -29,13 +29,12 @@ enum class RepeatMode { TRACK; /** Increment the mode, e.g from [NONE] to [ALL] */ - fun increment(): RepeatMode { - return when (this) { + fun increment() = + when (this) { NONE -> ALL ALL -> TRACK TRACK -> NONE } - } /** The integer code representing this particular mode. */ val intCode: Int @@ -48,13 +47,12 @@ enum class RepeatMode { companion object { /** Convert an int [code] into an instance, or null if it isn't valid. */ - fun fromIntCode(code: Int): RepeatMode? { - return when (code) { + fun fromIntCode(code: Int) = + when (code) { IntegerTable.REPEAT_MODE_NONE -> NONE IntegerTable.REPEAT_MODE_ALL -> ALL IntegerTable.REPEAT_MODE_TRACK -> TRACK else -> null } - } } } diff --git a/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt b/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt index 096f75866..51e09a115 100644 --- a/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt @@ -55,7 +55,7 @@ import org.oxycblt.auxio.util.systemBarInsetsCompat @Suppress("UNUSED") class SettingsListFragment : PreferenceFragmentCompat() { private val playbackModel: PlaybackViewModel by androidActivityViewModels() - private val indexerModel: MusicViewModel by activityViewModels() + private val musicModel: MusicViewModel by activityViewModels() override fun onViewCreated(view: View, savedInstanceState: Bundle?) { super.onViewCreated(view, savedInstanceState) @@ -129,7 +129,7 @@ class SettingsListFragment : PreferenceFragmentCompat() { } } getString(R.string.set_key_reindex) -> { - indexerModel.reindex() + musicModel.reindex() } else -> return super.onPreferenceTreeClick(preference) } diff --git a/app/src/main/res/values/styles_android.xml b/app/src/main/res/values/styles_android.xml index ef77f2244..669c65642 100644 --- a/app/src/main/res/values/styles_android.xml +++ b/app/src/main/res/values/styles_android.xml @@ -2,6 +2,25 @@ + + + + + + @@ -20,6 +39,7 @@ top|bottom + - - - - - - \ No newline at end of file diff --git a/app/src/main/res/values/styles_core.xml b/app/src/main/res/values/styles_core.xml index f6eab64f4..04bb53914 100644 --- a/app/src/main/res/values/styles_core.xml +++ b/app/src/main/res/values/styles_core.xml @@ -58,7 +58,6 @@ @style/TextAppearance.Auxio.BodySmall -